Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: fix pagination hook #667

Closed
ryuash opened this issue Jan 17, 2022 · 0 comments · Fixed by #672
Closed

Base: fix pagination hook #667

ryuash opened this issue Jan 17, 2022 · 0 comments · Fixed by #672
Labels

Comments

@ryuash
Copy link
Contributor

ryuash commented Jan 17, 2022

in src/hooks/use_pagination.ts

the following

const handleChangePage = (
    _event: React.MouseEvent<HTMLButtonElement, MouseEvent> | null,
    newPage: number,
  ) => {
    setPage(newPage);
    if (pageChangeCallback) {
      pageChangeCallback(page, rowsPerPage);
    }
  };

should be:

pageChangeCallback(newPage, rowsPerPage);
@ryuash ryuash added the base label Jan 17, 2022
@ryuash ryuash mentioned this issue Jan 19, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant