Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prettier to work against adx-template-json files #18

Open
smithgp opened this issue Dec 4, 2019 · 0 comments
Open

Enable prettier to work against adx-template-json files #18

smithgp opened this issue Dec 4, 2019 · 0 comments

Comments

@smithgp
Copy link
Contributor

smithgp commented Dec 4, 2019

With the fix for #5, to workaround microsoft/vscode#73424 not being implemented, the prettier vscode formatter will no longer format template json files, since those are now 'adx-template-json' languageId instead of 'json' or 'jsonc'.

We need to make it so prettier, when used in the vscode project, can be configured to format template json files, using prettier's default json formatting plugin and config.

Currently, I see how we could do it by directly modifying the vscodeLanaugeIds in prettier (e.g. in https://github.com/prettier/prettier/blob/master/src/language-js/index.js). Also, prettier/prettier-vscode#597 sound like what we want, but got closed pretty quickly w/o a fix.

I would like to have a vscode-only fix, either in our extension or in prettier/prettier-vscode, since the adx-template-json language id is currently only going to live in our vscode extension, and using prettier cli directly against template json files should work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant