Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode 1.29 causes sandbox retrieve/deploy commands to disappear from menu #748

Closed
DeborahOrth opened this issue Nov 14, 2018 · 10 comments
Closed
Assignees
Labels

Comments

@DeborahOrth
Copy link

DeborahOrth commented Nov 14, 2018

Summary

Install VSCode 1.29 and the right-click menu items SFDX: Delete, SFDX: Deploy and SFDX Retrieve This Source from Org are not available when working in a project created with -x for manifest file

Steps To Reproduce:

  1. Run SFDX force:project:create -n -x to create a new project
  2. cd
  3. code .
  4. right click on package.xml file in manifest folder - no items as listed above

Expected result

Should have had 3 menu items to delete, retrieve or deploy source from the default org

Actual result

items not available in menu

Additional information

Open a previous project that had been working just fine before 1.29 update and same menu items are gone. Re-install 1.26 VS Code and everything is back to working again

VS Code Version: 1.29

SFDX CLI Version: 6.38.0-0d66175ccf (darwin-x64) node-v8.9.4

OS and version: MacOS High Sierra v 10.13.6

@lcampos
Copy link
Contributor

lcampos commented Nov 14, 2018

Hi @DeborahOrth, this might be a documentation issue. Those commands are displayed if the org you have set as default for the project is a non-scratch org and are hidden if you are working with a scratch org.

Can you confirm which org type you are working with ?

@DeborahOrth
Copy link
Author

I only work with non-scratch orgs and I make sure each project I setup has a local default OAuth connection.

@keirbowden
Copy link

I saw the same thing when I upgraded from VS Code 1.28 to 1.29 - all the SFDX options (deploy, retrieve, delete from org) had disappeared from the manifest file right click menu. I tried re-installing the extensions etc, but no joy.

I then downloaded 1.28 of VS Code (didn't reinstall it, just executed it) and opened the project using that, and the menu options were back.

I then opened the project again in 1.29 of VS Code that was installed and they were back there too! Although with menu separators between each option.

@ntotten
Copy link
Contributor

ntotten commented Nov 15, 2018

We are looking into this and will try to get a resolution shortly.

@JimSuplizio
Copy link
Contributor

@DeborahOrth and @keirbowden
I'm following the steps that @DeborahOrth listed above and I'm kind of able to reproduce something. After creating the project, opening VS Code and opening the folder there's some time in which the Salesforce extensions are being loaded in which none of the right-click commands are available until the Salesforce extensions are loaded. I can close the folder and re-open it and reliably see that, until the extensions are loaded, the SFDX commands from right-clicking aren't there. This may or may not be exacerbated by other extensions. What I'd like to know is are you seeing the right-click options not there after immediately after loading a project folder and it goes away or when it happens do the commands stay gone?
My ask is this:

  1. Open up VS Code and ctrl-shift-p or cmd-shit-p and select Developer: Toggle Developer Tools and on that select the Console tab. This will show a trail of the Salesforce extensions being loaded when you open the project folder.
  2. Open up your project with the manifest file. If the right-click options are not there and the extensions are all loaded (the last line you'll see after everything is loaded is in activate, added breakpointsSub to subscriptions, activation complete).

I need to know if what I'm seeing is what you're seeing or if you're getting into a state where the right-click SFDX commands are never showing up (I haven't been able to make the latter happen).

Thanks,
Jim

@DeborahOrth
Copy link
Author

I tried with 1.29 again but kept getting an Extension host terminated unexpectedly message that gives me options to open Developer Tools or Restart Extension Host. Restart just leads to the same error so I opened Dev tools console which seemed to indicate that one of my other extensions was having an issue. I disabled it and reloaded VS Code and now everything is good. The time to load extensions seems to have slowed down a bit but eventually the delete/deploy/retrieve menu items do show up, including the new line separators. Thanks for all your help!

@keirbowden
Copy link

I've created a new project and gone through the same steps as before and now I see the menu items after a couple of seconds, with no errors in the console - previously I'd tried for about 30 minutes or so to get them to show, so I guess something had gone awry around extensions (and restarting with 1.28 handled it - who knows?).

Thanks for the tip about developer tools - I'll make sure to check that next time I see anything missing.

@DeborahOrth
Copy link
Author

I agree with Keir, I learned how to use the dev tools with VS Code to help diagnose my own issues, so thanks again.

@JimSuplizio
Copy link
Contributor

From @DeborahOrth's comment it looks like another extension (not a Salesforce one?) was causing things to not get loaded. Can you share which one that was?

@keirbowden if you encounter the same thing again and it's another extension can you also share which one it was? It's concerning and maybe VS Code needs to push out a better error message if something doesn't load which can cascade and cause other extensions to not load.

@DeborahOrth
Copy link
Author

I had problems with the Bracket Pair Colorizer 2 extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants