Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native appdelegate.m file uses old approach to js bundle location #107

Closed
socialsuiteDan opened this issue Jan 31, 2018 · 2 comments
Closed

Comments

@socialsuiteDan
Copy link

The template for React Native apps on iOS currently requires the user to comment/uncomment different lines of code to switch the js bundle location from the development server to the on-device packaged version. The standard template for react native apps has a different mechanism where the js bundle location is tied to which build configuration is being run, which is much easier to work with (and is already the way the Android build works). It looks like this was switched over quite a while back, around react native version 0.29.

Would it be possible to switch the appdelegate.m file in the SDK template to use the new approach? This would also make it much easier to install other react native libraries that modify the appdelegate.m file, as the installation steps typically expect the file to be based on the new template.

@wmathurin
Copy link
Contributor

Thanks for the feedback.
We will look at updating the template for our next release.

@wmathurin
Copy link
Contributor

Fixed in our next release: see #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants