refactor: return file as object for consumers and tests #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
added a commit
that referenced
this pull request
May 17, 2023
* fix: deletes singular CL when from CLs when specified * chore: ensure array when deleting last CL in CLs * chore: delete entire CL when last one deleted, return multiple FileResponses for multiple CL * chore: use promise array * chore: small tweak, get CI running * chore: bump sdr * chore: bump core * chore: more bugs caught by extNuts fixed * chore: move CL delete to static method * test: add UT for static method * chore: top level function, other review improvements * chore: bump testkit * chore: remove deleting CLs from other methods * refactor: return file as object for consumers and tests (#388) * refactor: return file as object for consumers and tests * chore: dedupe pjson --------- Co-authored-by: mshanemc <shane.mclaughlin@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?