Sign up flow confirmation email error message #18555
Replies: 3 comments
-
GH SSO, on my local machine, works as expected when following Dev Forem Docs - GH Auth. And the user created (on my local when testing signup via GH SOO) is indeed created as confirmed email address. Below is the code that creates the user: forem/app/services/authentication/authenticator.rb Lines 116 to 137 in 81d981d Line 131 above makes it clear that the user is created confirmed. I've tested this a couple of times on my local machine and the insert query always goes with
There is however a path into which I could have been redirected to forem/app/controllers/omniauth_callbacks_controller.rb Lines 59 to 70 in 81d981d All my tests reached the first if clause where the @user is confirmed. So, my assumption is another repository triggered the email confirmation, without validating the DB record created above. Next up, I will try to simulate an email confirmation email, and look at the page link I got on my inbox, which could use some improvements (in the event a confirmed email user do get an email confirmation email/link). |
Beta Was this translation helpful? Give feedback.
-
This discussion has become stale and will be closed. |
Beta Was this translation helpful? Give feedback.
-
I just had an issue that is somewhat related to this. So, I've tried to sign up, still using my GH id.
And after I go through the wizard, I am sure some error happens in the backend and sends me back to the first page of the onboarding. Maybe next Friday I will give it a shot! :-D Right now, if I open https://community.codenewbie.org/ on the browser, I see the CodeNewbie Forem page and I get redirect to the onboarding URL, but as I said above, it fails after the last step of the wizard and takes me back again to the first step of the onboarding wizard! |
Beta Was this translation helpful? Give feedback.
-
While creating my account on Dev.to I got an email confirmation email with a link to confirm it.
I signed up using GitHub SSO, so it was somewhat surprising the email, but I clicked in the link anyway.
And the result is an error page that is a bit more confusing with a red message (indicating error) that possibly should not be red...
But the error says I can't confirm my email because it is already confirmed, which makes sense, given I created my account through GitHub SSO.
With that said, here is what I'd expect the logic to be:
I managed to get Forem setup on my local machine and I am currently investigating this issue.
My next goal is to setup GH SSO on my local (GH Auth), so I can try to replicate the issue.
Beta Was this translation helpful? Give feedback.
All reactions