Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter liquid tags not working on new Forems #10836

Open
pkfrank opened this issue Oct 13, 2020 · 4 comments
Open

Twitter liquid tags not working on new Forems #10836

pkfrank opened this issue Oct 13, 2020 · 4 comments
Labels
bug always open for contribution internal team only internal tasks only for Forem team members type: forem creation related to setting up a new instance

Comments

@pkfrank
Copy link
Contributor

pkfrank commented Oct 13, 2020

Describe the bug
As an author of a new Forem, I'm unable to use the Twitter liquid tag.

To Reproduce
Try and publish a post with this text on Forem.dev: {% twitter 1316121872312958976 %}

Expected behavior
The liquid tag creates a beautiful embed, as happens on dev.to.

Screenshots
error when trying to publish a post with a Twitter liqiud tag on forem.dev

@github-actions
Copy link
Contributor

Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

@citizen428
Copy link
Contributor

citizen428 commented Oct 14, 2020

Does forem.dev have correct Twitter credentials set in the environment? "Bad Authentication data" sounds a lot like we may be trying to use a dummy key or something.

@citizen428 citizen428 added internal team only internal tasks only for Forem team members bug always open for contribution type: forem creation related to setting up a new instance labels Oct 14, 2020
@shar1z
Copy link

shar1z commented Oct 18, 2020

I actually believe this is a global issue - as the Github images are broken as well. (I embedded a pull request into a post and it also appears to be broken).

@cmgorton
Copy link
Contributor

Twitter embeds seem to work now but when I test them out they display the reactions weird.
Screen Shot 2021-01-28 at 9 28 38 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution internal team only internal tasks only for Forem team members type: forem creation related to setting up a new instance
Projects
None yet
Development

No branches or pull requests

4 participants