Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving using 'label' icon on post and going back and clicking save unsaved the article #11393

Open
YJDoc2 opened this issue Nov 12, 2020 · 2 comments
Labels
area: homepage homepage and feed area: mobile any tasks relating to iOS and Android mobile apps bug always open for contribution

Comments

@YJDoc2
Copy link

YJDoc2 commented Nov 12, 2020

Describe the bug
Using mobile version,
When one clicks label icon to save the post, and goes back to home page by back button on mobile , the 'save' button on the post is still there, which is probably as the browser caches the page, and is expected, but clicking on the save button changes it 'saved' while actually unsaving the article from reading list. One more click keeps the 'saved' but saves the article again, and clicking again changes the button to 'unsave' clicking on which removes it from saved articles and changes the button to 'save' again

To Reproduce

  1. On mobile, open side panel and note number of saved articles
  2. Go to any article
  3. Save article by clicking on label icon in bottom, which ia along with heart and unicorn
  4. Click on back button on mobile
  5. Check the saved articles, by opening sidebar, it should be increased by one (closing the side bar makes the article list weirdly jump upward, not sure if it's another bug or intended)
  6. The button on article should still be saying save
  7. Click the save button, it should change it to saved , but the number of saved articles will now return to original

Expected behavior
Even though clicking back would display save button only, (probably due to browser caching the page) clicking on it should not unsave the article, just change the button to say saved.

Smartphone (please complete the following information):

  • Android 10:
  • Chrome 86.0:
@github-actions
Copy link
Contributor

Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

@rhymes rhymes added area: homepage homepage and feed area: mobile any tasks relating to iOS and Android mobile apps bug always open for contribution labels Nov 12, 2020
@YJDoc2
Copy link
Author

YJDoc2 commented Nov 12, 2020

I do not have much experience developing Ruby applications, but if someone can point to a possible starting point, I'd like to try and solve this.
As much as I have understood till now, a possible starting point would be to look in /app/javascript/articles/Feed.jsx, and have been trying to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: homepage homepage and feed area: mobile any tasks relating to iOS and Android mobile apps bug always open for contribution
Projects
None yet
Development

No branches or pull requests

2 participants