Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an inline upload button component on the Config Page #11592

Open
Ridhwana opened this issue Nov 24, 2020 · 3 comments
Open

Add an inline upload button component on the Config Page #11592

Ridhwana opened this issue Nov 24, 2020 · 3 comments
Labels
area: admin admin panel area: images serving and manipulating images

Comments

@Ridhwana
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently we have an image upload button that can be found at http://localhost:3000/admin/tools. We want to reuse the image upload functionality across the admin interface whereby admins can upload images inline. This is especially important on http://localhost:3000/admin/config.

Describe the solution you'd like

Find all instances where an admin can provide a URL for an image on http://localhost:3000/admin/config, and allow them to add an image via upload in these fields.

The upload can go next to the image URL fields, similar to leaving comments in the main Forem experience. When you click upload image, it will upload and fill the image field. This should be a re-usable component across the config area.

@github-actions
Copy link
Contributor

Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

@Ridhwana
Copy link
Contributor Author

Ridhwana commented Nov 24, 2020

@ludwiczakpawel and @lisasy do either of you think that this needs a light design? It seems straightforward but maybe a small mockup would be beneficial in keeping within the goals of what we'd like the config page to look like.

@lisasy
Copy link
Contributor

lisasy commented Nov 25, 2020

Hey @Ridhwana,

This looks good. I thought it would be most efficient to sketch out this sample flow as a possible solution; can you look at this and let me know if these are the right steps and types of information we can display? Let me know if you need any clarification :)
IMG_3311

@cmgorton cmgorton added area: images serving and manipulating images and removed area: image uploading labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: admin admin panel area: images serving and manipulating images
Projects
None yet
Development

No branches or pull requests

3 participants