Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Podcast title text colour and/or make "Pattern Image" a mandatory field for Suggest a Podcast form #13248

Open
ellativity opened this issue Apr 5, 2021 · 1 comment

Comments

@ellativity
Copy link

Describe the bug
The Podcast page always displays title text in white on a white background, regardless of the user's theme. .

Right now, the Suggest a Podcast form can be submitted without uploading a Pattern Image, which means that when the podcast is approved, the title text is white type on a light background (irrespective of selected theme).

To Reproduce

  1. Go to Suggest a Podcast
  2. Submit a podcast without uploading a Pattern Image
  3. Go to Podcast Admin
  4. Approve the podcast by scrolling to the bottom of the page and checking the Published box and clicking Update Podcast button
  5. View podcast page by scrolling to the top of the page and clicking the View button
  6. Toggle between themes to see if it's just you
  7. Cry

Main podcast title page
Episode title page
Episode title page with text selected to demonstrate it's there

Expected behavior

Either the podcast title text displays dark-on-light and light-on-dark, or the Suggest a Podcast form doesn't allow for a podcast to be submitted without uploading a Pattern Image (and specifies why).

Additional context

This is pretty much an admin issue, since we end up fixing the cases where a podcast is submitted without a background and the text is invisible. However, we have no way of knowing that a background wasn't uploaded until we publish the podcast and view the page for ourselves, so it's an extra bunch of steps:

  1. find a suitable background for the podcast
  2. go back to the podcast edit page
  3. upload the background
  4. view again to make sure it worked this time.

There is also an issue of uploaded pattern images tiling in unattractive ways, but it's the least of our concerns right now... (see all the screenshots)

Main podcast title page with tiled background image
Episode title page with tiled background image

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@ellativity ellativity changed the title Either change Podcast title text colour for light themes and/or make "Pattern Image" a mandatory field for Suggest a Podcast form Either change Podcast title text colour and/or make "Pattern Image" a mandatory field for Suggest a Podcast form Apr 5, 2021
@ellativity ellativity changed the title Either change Podcast title text colour and/or make "Pattern Image" a mandatory field for Suggest a Podcast form Change Podcast title text colour and/or make "Pattern Image" a mandatory field for Suggest a Podcast form Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant