Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/config > Authentication doesn't update when the invite-only box is checked/unchecked #15658

Open
ellativity opened this issue Dec 2, 2021 · 1 comment
Labels
area: admin admin panel area: auth authentication and authorization issues changelog: rollup Items that will be communicated in our monthly rollup changelogs internal team only internal tasks only for Forem team members

Comments

@ellativity
Copy link

ellativity commented Dec 2, 2021

Describe the bug

Checking or unchecking the box for the Invite-only setting under Authentication in /config displays a snackbar that appears to confirm the change, but the page doesn’t update.

This means you can’t modify any authentication methods until you refresh the page, scroll back to the point you were at, and then expand Authentication again.

To Reproduce

  1. navigate to Customization > Config > Authentication
  2. Check or uncheck the Invite-only checkbox
  3. Notice that the confirmation is displayed in the bottom of the screen but behaviour doesn't change for authentication options (i.e. if unchecking the box, it's not possible to enable any of the authentication options without an error tooltip appearing "You cannot do this until you disable Invite Only Mod"; if checking the box, any enabled authentication methods remain enabled).

Expected behavior
The page updates to behave differently, rather than just displaying a confirmation with no change in behaviour.

Additionally

The user experience feels like the change isn’t saving in spite of the snackbar, because the functionality doesn’t change. In reality, Email Authentication is enabled by default and there’s no visible indication of this unless the user knows to follow the steps above. This means that users may inadvertently enable Email Authentication whilst believing they have made no changes.

Screenshots
Screenshot 2021-12-02 at 21 18 14
Screenshot 2021-12-02 at 21 27 41

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@juliannatetreault juliannatetreault added area: admin admin panel area: auth authentication and authorization issues internal team only internal tasks only for Forem team members labels Dec 2, 2021
@JennieOcken JennieOcken added the changelog: rollup Items that will be communicated in our monthly rollup changelogs label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: admin admin panel area: auth authentication and authorization issues changelog: rollup Items that will be communicated in our monthly rollup changelogs internal team only internal tasks only for Forem team members
Projects
None yet
Development

No branches or pull requests

3 participants