Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab widths in Analytics Dashboard #15873

Open
yheuhtozr opened this issue Dec 24, 2021 · 2 comments
Open

Tab widths in Analytics Dashboard #15873

yheuhtozr opened this issue Dec 24, 2021 · 2 comments
Labels
area: design Use for all tasks related to UX, UI, visual, or interaction design. area: internationalization/localization i18n and l10n

Comments

@yheuhtozr
Copy link
Contributor

yheuhtozr commented Dec 24, 2021

Describe the bug

The analytics period selection tabs in the analytics page (app/views/shared/_stats.html.erb) would have line break at spaces or hyphens, if translated text should contain them. What is worse, it will break at every single character in break-anywhere languages,

To Reproduce

Supply translation to each tab's text and data-text. For example,

      period:
        aria_label: Analytics period
        week: Week this
        month: Month-ly
        infinity: 锟斤拷

See the screenshot.

Expected behavior

For the convenience of i18n alone, an obvious solution is to change the following line from min-content to max-content, then each tab's text will be contained in one line.

width: min-content;

But why is this rule introduced and what does it serve for? To what extent is this an expected design?

Screenshots

image

Desktop (please complete the following information):

  • OS, version: Windows 10
  • Browser, version: Chrome 96
@github-actions
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@citizen428 citizen428 added area: design Use for all tasks related to UX, UI, visual, or interaction design. area: internationalization/localization i18n and l10n labels Dec 27, 2021
@citizen428
Copy link
Contributor

Pinging @ludwiczakpawel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: design Use for all tasks related to UX, UI, visual, or interaction design. area: internationalization/localization i18n and l10n
Projects
None yet
Development

No branches or pull requests

2 participants