Error with "Add comment" button appearing as [missing "en.core.add_comment" translation]

[michael-tharrington]

Describe the bug

Occasionally, when looking at a Forem in feed view (e.g. the main feed on dev.to or https://dev.to/latest or https://dev.to/top/week) the "Add comment" button is appearing as [missing "en.core.add_comment" translation].

To Reproduce

It's unclear to me how to reproduce this, but I've noticed it happening enough to want to raise the issue.

Expected behavior

The button should consistently appear as "Add comment" rather than [missing "en.core.add_comment" translation].

Screenshots

[github-actions]

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

[djuber]

That is super odd - those translations were there since October (they're not new) - both added in #14852

I think those errors are from the front end <CommentsCount /> component - it's possible the navigation from a page where the locale didn't include this (the front-end accessible keys should be loaded into a div via the application layout template) or overwrote it, but I don't see anywhere we're overwriting this, and you would likely see lots of other missing translations if that were happening (search and follow labels could also be showing problems).

I wonder if it's happening to you specifically, navigating from some path under /admin (which has a different base layout, and doesn't appear to include the core translations div or inherit the application layout) to the feed (which would have included the translations on the page from the base layout, but might not do that if instant click is making the page transition).

[michael-tharrington]

Hmmm... this does sound like a strange one!

You know, I have seen this happen to me, but I'm actually reporting this on behalf of a Forem Creator (probably should've included that context)... I didn't take this picture actually, just delivering the news.

The person who took it does have super admin privileges on their Forem though, so they could've be navigating from /admin and encountered this. 🤔

[metamoni]

Could it be that, sometimes, this component loads before the translations are fully loaded? 🤔