Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add critical flow / "smoke" tests in Cypress #18274

Open
aitchiss opened this issue Aug 4, 2022 · 1 comment
Open

Add critical flow / "smoke" tests in Cypress #18274

aitchiss opened this issue Aug 4, 2022 · 1 comment
Labels
area: tests issues related to tests internal team only internal tasks only for Forem team members

Comments

@aitchiss
Copy link
Contributor

aitchiss commented Aug 4, 2022

Since introducing Cypress E2E testing, we've largely added tests as we introduce new features, and we haven't really taken stock of what our critical flows are. For example, we don't have any E2E tests for the onboarding flow, despite this arguably being one of the most important user flows in the app.

I'm creating this issue more as a 'suggestion', and whoever takes it forward can perhaps lead a discussion within the engineering team of how we want to do things, but I would suggest we create a folder of "smoke tests" - i.e. the minimal set of tests that give us early indication of something critical being broken (e.g. user sign up, sign in, post creation).

This would help give us confidence in refactors, but we could also consider in the future whether we want to only run the smoke tests on each PR build (to speed up build times).

@aitchiss aitchiss added area: tests issues related to tests internal team only internal tasks only for Forem team members labels Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests issues related to tests internal team only internal tasks only for Forem team members
Projects
None yet
Development

No branches or pull requests

1 participant