Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML <a> tag gets rendered as HTML instead ov being written as text in the notification menu. #19553

Open
CalinZBaenen opened this issue May 29, 2023 · 5 comments
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@CalinZBaenen
Copy link

Bug

In the notifications menu, my post's title, How can I remove the "padding"-like stuff on the `<a>`?, becomes How can I remove the "padding"-like stuff on the ``?.
Image ov the post title being incorrectly displayed.
Here is what it looks like when viewing the post title from the inspector:
Image ov the menu with the inspector.
... and again with the relevant areas being highlighted:
Image ov the menu with the inspector being highlighted.
However, this bug does not happen when someone is commenting on your post; for example, consider this notification for a comment left by @foxy4096:
Image ov the notification for Aditya's message.
Additionally, as far as I'm concerned, it only works with the <a> tag, but I did not really have that many tags in my title.
Image ov another post with HTML tags in the title.

Reproduction

Go into the notifications menu after someone likes your post, I suppose; I am not sure what else I can say.

  1. Make a post good enough so that at least one person will leave a reaction.
  2. Make sure the syntax for a code snippet, two backticks, syntax is in your title, and in the "code-snippet", put an HTML tag like <a>.
  3. See what it looks like in the notification menu

Expected Behavior

I expected to see `<a>`?, not ``?.

System Information

Ubuntu (Jammy Jellyfish), 22.04.2 LTS, x86_64.
Firefox, 113.0.1, 64-bit.

@github-actions
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@PhilipHow PhilipHow added bug always open for contribution external contributors welcome contribution is welcome! labels Sep 12, 2023
@zainbinfurqan
Copy link

Can i work on this issue?

@CalinZBaenen
Copy link
Author

CalinZBaenen commented Oct 1, 2023

I would hope that you are allowed to — someone needs to get to it, as I can't imagine this bug is pleasant, even if it isn't doing much harm.  (I feel like this could be concidered an accessibility concern.)

@danielmbrasil
Copy link
Contributor

Hey @CalinZBaenen, could you confirm if it's still an issue?

I've tried to replicate it using exactly the same title as your post and some other alternatives using the <a> tag, but without success. As you can see in the following screenshot:
image

Maybe this already got fixed in main or I'm simply missing something.

@CalinZBaenen
Copy link
Author

I think it has been patched out, as your screenshot indicates.
(Though, I'm unsure at what point it was fixed;  I feel like my issue should have been closed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
Development

No branches or pull requests

4 participants