Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "New organization" button to /settings/organization #19896

Closed
2 tasks
PhilipHow opened this issue Aug 4, 2023 · 14 comments · Fixed by #20014
Closed
2 tasks

Add "New organization" button to /settings/organization #19896

PhilipHow opened this issue Aug 4, 2023 · 14 comments · Fixed by #20014
Assignees
Milestone

Comments

@PhilipHow
Copy link
Contributor

PhilipHow commented Aug 4, 2023

Is this feature related to a problem? Please describe.

  • It is currently unintuitive for a user to create a second organization, having to select "New Organization" from the drop-down list of Organizations.

Definition of Done

  • Replace the element in the dropdown selector for a "Create or join organization" button on the /settings/organization page, when viewing an existing organization.
  • Remove the heading on the page, ensuring there is enough top margin to compensate (see designs).

Design - Figma link

With changes

@PhilipHow PhilipHow added internal team only internal tasks only for Forem team members needs design labels Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@ferrorenan
Copy link

Hey person, I would like to resolve this issue. Can I get her?

@PhilipHow
Copy link
Contributor Author

@ferrorenan Unfortunately, this issue is tagged as Forem team meaning this is intended for our internal team members to tackle.

If you're comfortable with our front-end codebase and you're willing to give this a go then I'm happy to assign - however please be prepared to have your PR rejected or have lots of feedback if it doesn't meet our standards or isn't completed in ~1 week.

Let me know if this is okay and I'll assign! Otherwise please have a look at our other issues labelled Ready for Dev.

@ferrorenan
Copy link

Yes, I would like to try! And I would be happy with the good or bad feedbacks :)

@PhilipHow
Copy link
Contributor Author

Okay @ferrorenan - please make sure you've taken a look at our contributors guide .

Could you get a PR out this week?

@PhilipHow PhilipHow assigned ferrorenan and unassigned anujbhavsar96 Aug 9, 2023
@PhilipHow PhilipHow removed internal team only internal tasks only for Forem team members needs design labels Aug 9, 2023
@PhilipHow PhilipHow added this to the OSS milestone Aug 9, 2023
@narender2031
Copy link
Contributor

narender2031 commented Aug 28, 2023

Hey @PhilipHow This seems to be pending from the few weeks, I'm interested to solve this task, Can you please assign this to me. Also i'm familiar with the org and article code base.

@narender2031
Copy link
Contributor

@PhilipHow @rt4914 Can you please share me the figma access, I am ready with half of the PR. Need to finish the UI Changes and button changes.

@rt4914
Copy link
Contributor

rt4914 commented Aug 29, 2023

HI @narender2031 Currently I person who can provide you access to this file is on leave. But that should not block your work.
Have a look at below screenshot. Mainly focus on before(left) vs after(right) part of it. And I do understand that you are looking for various attributes like font, text-size, color and all but for that you can try to find similar buttons in that codebase, inspect them and see what all css classes they use and directly use them in your button. This is the cleanest way to implement consistent UI at Forem.

image

That being said its completely fine if something looks off in implementation, we can always fix that during PR review.

Hope this unblocks you. :-)

@narender2031
Copy link
Contributor

Thanks @rt4914 This information is sufficient.

@PhilipHow PhilipHow assigned narender2031 and unassigned ferrorenan Aug 30, 2023
@PhilipHow
Copy link
Contributor Author

@narender2031 All yours.

@narender2031
Copy link
Contributor

@PhilipHow @rt4914 I have encountered with an edge case, If user click on button create or join organization, There is no way to go back. So i have introduced the back button from there. Please review the solution and feel free to add the suggestions.

Screenshot 2023-08-30 at 10 22 20 PM Screenshot 2023-08-30 at 10 23 24 PM Screenshot 2023-08-30 at 10 23 40 PM Screenshot 2023-08-30 at 10 23 49 PM

@PhilipHow
Copy link
Contributor Author

@anujbhavsar96

@anujbhavsar96
Copy link

@narender2031 The back button is not there intentionally because you can always navigate back via the sidebar. And even in our admin platform, we don't have a back button for such flow. In the future, when we do a re-design exercise, we will introduce a back button/icon with consistent styling.

@narender2031
Copy link
Contributor

@anujbhavsar96 It's done and updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants