Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodePen Embeds Do Not Follow Our Embed Formula #20134

Open
michael-tharrington opened this issue Sep 18, 2023 · 3 comments
Open

CodePen Embeds Do Not Follow Our Embed Formula #20134

michael-tharrington opened this issue Sep 18, 2023 · 3 comments
Labels
bug always open for contribution

Comments

@michael-tharrington
Copy link
Contributor

michael-tharrington commented Sep 18, 2023

Describe the bug

CodePen embeds don't follow the formula we've established for embeds here:

{% embed https://... %}

You can get them to work by using the following embed syntaxes:

{% codpen https://... %}

To Reproduce

  1. Try to embed this CodePen on DEV {% embed https://codepen.io/cassidoo/pen/MyaWzp %}
  2. It fails.
  3. Try to embed a CodePen on DEV with the following syntax:
    {% codepen https://codepen.io/cassidoo/pen/MyaWzp %}
  4. It works!

Expected behavior

All embeds should use the following formula: {% embed https://... %}

I do think it'd be ideal if we could still allow folks to use the current formulas too. That way folks who are used to using these formulas don't think something has broken.

Additional context

Shoutout to @Dumebii for pointing out this issue to me and for writing up this post to try and help folks with using embeds on DEV - https://dev.to/dumebii/how-to-use-embeds-on-your-dev-community-blogposts-3oe5.

@michael-tharrington michael-tharrington added the bug always open for contribution label Sep 18, 2023
@github-actions
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@ktmouk
Copy link
Contributor

ktmouk commented Oct 8, 2023

I tried the formula below and the CodeSandbox embed seems to work fine on dev.to now.
Has this bug already been fixed?

{% embed https://codesandbox.io/embed/relaxed-franklin-mv8rng?fontsize=14&hidenavigation=1&theme=dark %}
スクリーンショット 2023-10-08 12 12 41

@michael-tharrington
Copy link
Contributor Author

I know I'm way delayed on this, but sorry I missed your message @ktmouk — you are correct! I'll edit my request accordingly.

@michael-tharrington michael-tharrington changed the title CodeSandbox and CodePen Embeds Do Not Follow Our Embed Formula CodePen Embeds Do Not Follow Our Embed Formula Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution
Projects
Development

No branches or pull requests

2 participants