Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Purchase button needs debounce #5719

Open
pioardi opened this issue Jan 24, 2020 · 2 comments
Open

Complete Purchase button needs debounce #5719

pioardi opened this issue Jan 24, 2020 · 2 comments
Labels
bug always open for contribution

Comments

@pioardi
Copy link

pioardi commented Jan 24, 2020

Describe the bug
Purchase credits | When you insert your credit card info and then click twice the button "Complete Purchase" you are purchase twice .

To Reproduce

  1. Go to create/manage listings
  2. Go to buy credits
  3. Insert your amount and your card info
  4. Click Complete Purchase two times quickly.

Expected behavior
The second click should not have effect

Desktop (please complete the following information):

  • Device: Mac Book Pro 2015
  • OS:
  • Browser: Safari
  • Version:
@rhymes rhymes added area: listings bug always open for contribution labels Jan 26, 2020
@moacirguedes
Copy link

moacirguedes commented Feb 5, 2020 •
edited

I will work on this

@rhymes
Copy link
Contributor

rhymes commented Feb 5, 2020

@moacirguedes a suggestion for debounce: we already have the library lodash.debounce in the code. You can find an example here:

https://github.com/thepracticaldev/dev.to/blob/6a100415cc9ec5008095e127c4597411b7f7fdad/app/javascript/readingList/readingList.jsx#L42-L44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug always open for contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joshpuetz @rhymes @moacirguedes @pioardi @cmgorton