Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile image from article liquid tag not displaying when nested as part of a liquid tag comment #6081

Open
pkfrank opened this issue Feb 14, 2020 · 2 comments
Labels
area: media images, videos, podcasts, liquid tags, etc. bug always open for contribution

Comments

@pkfrank
Copy link
Contributor

pkfrank commented Feb 14, 2020

Describe the bug

Comment A references a DEV article using the {% link %} liquid tag.

Article and/or Comment B references Comment A using the {% devcomment %} liquid tag.

The article links contained with Comment A are not displaying the profile image correctly.

Expected behavior

Images show up correctly.

Additional Info:

Screenshots
screenshot of bug

@Zhao-Andy
Copy link
Contributor

This is just off the top of my head but I believe the issue is that the inner Liquid tag embed (top 5 DEV comments) is calling our Cloudinary image method and therefore a double nested URL happens. Here's an example from production from my dev tools' Network tab, where the URL shows up twice:

Screen Shot 2020-02-14 at 2 28 37 PM

@Zhao-Andy Zhao-Andy added area: liquid tags bug always open for contribution labels Feb 14, 2020
@cmgorton cmgorton added area: media images, videos, podcasts, liquid tags, etc. and removed area: liquid tags labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: media images, videos, podcasts, liquid tags, etc. bug always open for contribution
Projects
None yet
Development

No branches or pull requests

4 participants