Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fastly-Rails Gem #838

Closed
Zhao-Andy opened this issue Oct 5, 2018 · 11 comments
Closed

Use Fastly-Rails Gem #838

Zhao-Andy opened this issue Oct 5, 2018 · 11 comments

Comments

@Zhao-Andy
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We have an custom version of clearing our cache through Fastly, that involves URLs. The fastly-rails gem could streamline our process and make things smoother.

Describe the solution you'd like
We decide on whether or not to use the fastly-rails gem.

@benhalpern
Copy link
Contributor

We do use Fastly-Rails gem already, but we don't follow it's exact prescribed cache clearing solution, mostly because we couldn't get it to work at first.

I'm in favor of continuing to look into improvements here.

@stale
Copy link

stale bot commented Jan 7, 2019

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 7 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

@stale stale bot added the stale label Jan 7, 2019
@Zhao-Andy
Copy link
Contributor Author

Believe we still want to do this.

@stale stale bot removed the stale label Jan 8, 2019
@stale
Copy link

stale bot commented Apr 8, 2019

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 7 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

@stale stale bot added the stale label Apr 8, 2019
@rhymes
Copy link
Contributor

rhymes commented Apr 8, 2019

still an issue

@stale stale bot removed the stale label Apr 8, 2019
@rhymes
Copy link
Contributor

rhymes commented Jul 22, 2019

@stale
Copy link

stale bot commented Jan 19, 2020

Thanks for contributing to this issue. As it has been 180 days since the last activity, we are automatically closing the issue in 30 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

@stale stale bot added the stale label Jan 19, 2020
@rhymes
Copy link
Contributor

rhymes commented Jan 19, 2020

I believe we should keep this open. With everything we're learning now, through #4744 and #5543 we'll eventually use fastly and fastly-rails more effectively, instead of manually calling endpoints with HTTParty

@stale stale bot removed the stale label Jan 19, 2020
@rhymes
Copy link
Contributor

rhymes commented Jan 19, 2020

@tannakartikey
Copy link
Contributor

tannakartikey commented Apr 10, 2020

@rhymes fastly-rails gem is deprecated. I am trying to give Rails update(#2879) a try and stumbled upon your comments there:
fastly/fastly-rails#87 (comment)

Should we change the title of this issue to "Use fastly gem" and then actually use it? fastly gem is compatible with Rails 6.

@rhymes
Copy link
Contributor

rhymes commented Apr 10, 2020

Hi @tannakartikey, thanks for the update!

Indeed is deprecated. We're in the process of removing the fastly-rails gem, see:

I'd suggest you hit the pause button on this, at least until we've finished the process and updated fastly-ruby and verified everything works in production.

I'm going close this in the meantime as we're going in the opposite direction :)

If you don't mind I'm going to reserve the Rails 6 upgrade path issue to the DEV team as we've other blockers likely and we need to verify that everything works with our custom defaults (we don't use all the defaults of Rails 5.2 for example).

Let me know if you have questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants