Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed check command cargo check --all didn't succeed. #124

Closed
Animeshz opened this issue Oct 6, 2021 · 3 comments
Closed

Failed check command cargo check --all didn't succeed. #124

Animeshz opened this issue Oct 6, 2021 · 3 comments

Comments

@Animeshz
Copy link

Animeshz commented Oct 6, 2021

The command cargo check --all externally works, but says: Bad check for 1.55.0 and fails with the above message.

  eww on  current [$⇡] via  v14.17.2 via 🦀 v1.56.0-nightly took 1m40s >>> cargo check --all
    Checking eww v0.2.0 (/home/animesh/Projects/eww/crates/eww)
    Finished dev [unoptimized + debuginfo] target(s) in 10.64s

  eww on  current [$⇡] via  v14.17.2 via 🦀 v1.56.0-nightly took 10s >>> cargo msrv
Determining the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu
Using check command cargo check --all
   Done Bad check for 1.55.0      █░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 00:00:35
   Failed check command cargo check --all didn't succeed
Unable to find a Minimum Supported Rust Version (MSRV).

If you think this result is erroneous, please run: `cargo check --all` manually.

If the above does succeed, or you think cargo-msrv errored in another way, please feel free to
report the issue at: https://github.com/foresterre/cargo-msrv/issues

Thank you in advance!
@foresterre
Copy link
Owner

Thanks for the report!

@foresterre
Copy link
Owner

I didn't have a proper look yet, but I saw that eww by default seems to rely on nightly releases which we don't support yet.

Specifically, the rust-toolchain file in the eww repo contains 'nightly-2021-08-10'. I didn't check whether the crates themselves actually opt in to nightly features yet.

@foresterre
Copy link
Owner

Regardless, if that's indeed the issue, the error message should be improved 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants