You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This comes from the forever cli project but issue is in the monitor watcher plugin:
Scenario: include multiple --watchDirectory='somepaths' in a forever start command.
Expected: watch multiple directories Actual: throws exception:
TypeError: Path must be a string. Received [ '/var/www/myproject/services/engine',
'/var/www/myproject/lib/nodejs' ]
at assertPath (path.js:7:11)
at Object.join (path.js:1213:7)
at exports.attach (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/plugins/watch.js:54:20)
at Object.bootstrap (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:36:28)
at exports.App (/usr/local/lib/node_modules/forever/node_modules/broadway/lib/broadway/app.js:47:21)
at new exports.Monitor (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:139:16)
at start (/usr/local/lib/node_modules/forever/bin/monitor:23:17)
at process. (/usr/local/lib/node_modules/forever/bin/monitor:85:5)
at emitTwo (events.js:106:13)
at process.emit (events.js:191:7
It's constructed as a string array as chokidar requests but the watcher plugin throws an exception on line 54 when this.watchDirectory is a string array. It expects a string.
Didn't have time to see if multiple .foreverignore would work, but IMO, the watcher plugin should either iterate through items and use multiple .foreverignore files or use a '.foreverignore' in a single location of the command context instead of the watchDirectory.
LE: watchFilter uses this.watchDirectory too, so that needs fixing as well, so it works with array.
The text was updated successfully, but these errors were encountered:
alex7071
added a commit
to alex7071/forever-monitor
that referenced
this issue
Dec 1, 2016
This comes from the forever cli project but issue is in the monitor watcher plugin:
Scenario: include multiple --watchDirectory='somepaths' in a forever start command.
Expected: watch multiple directories
Actual: throws exception:
TypeError: Path must be a string. Received [ '/var/www/myproject/services/engine',
'/var/www/myproject/lib/nodejs' ]
at assertPath (path.js:7:11)
at Object.join (path.js:1213:7)
at exports.attach (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/plugins/watch.js:54:20)
at Object.bootstrap (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:36:28)
at exports.App (/usr/local/lib/node_modules/forever/node_modules/broadway/lib/broadway/app.js:47:21)
at new exports.Monitor (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:139:16)
at start (/usr/local/lib/node_modules/forever/bin/monitor:23:17)
at process. (/usr/local/lib/node_modules/forever/bin/monitor:85:5)
at emitTwo (events.js:106:13)
at process.emit (events.js:191:7
It's constructed as a string array as chokidar requests but the watcher plugin throws an exception on line 54 when this.watchDirectory is a string array. It expects a string.
Didn't have time to see if multiple .foreverignore would work, but IMO, the watcher plugin should either iterate through items and use multiple .foreverignore files or use a '.foreverignore' in a single location of the command context instead of the watchDirectory.
LE: watchFilter uses this.watchDirectory too, so that needs fixing as well, so it works with array.
The text was updated successfully, but these errors were encountered: