Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading hyphen in log file names #178

Closed
bmount opened this issue Nov 28, 2011 · 2 comments
Closed

Leading hyphen in log file names #178

bmount opened this issue Nov 28, 2011 · 2 comments

Comments

@bmount
Copy link
Contributor

bmount commented Nov 28, 2011

Not sure if this is yet a violation of posix but probably not the right behavior (http://www.dwheeler.com/essays/fixing-unix-linux-filenames.html#dashes http://www.opengroup.org/austin/docs/austin_224.txt ).

Am not competent to suggest best fix but easy first pass that preserves approximately equivalent randomness is just:

// lib/forever.js line 325

options.uid = options.uid || utile.randomString(4).replace(/^\-/, 'H')

If you are in touch with the utile developer might be nice to have optional chars argument for cases like this.

@AvianFlu
Copy link
Contributor

We would accept a pull request here, as well as for your idea for utile.

@bmount
Copy link
Contributor Author

bmount commented Nov 30, 2011

Pull request sent for first part of above, https://github.com/bvmou/forever/commit/65f2f5d611475c05fc51738bf64269926d1f2daa

utile is kind of sophisticated and nice, don't want to muck up but maybe will try a simple base32 option for keyboard- and shell-friendly filenames. Thanks AvianFlu.

@bmount bmount closed this as completed Nov 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants