Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for node v0.8 #297

Closed
AvianFlu opened this issue Jun 17, 2012 · 7 comments
Closed

Refactor for node v0.8 #297

AvianFlu opened this issue Jun 17, 2012 · 7 comments

Comments

@AvianFlu
Copy link
Contributor

Refactor forever to take advantage of the new child process APIs. This is already in progress, and backwards compatibility with node 0.6.x will be maintained.

@ghost ghost assigned AvianFlu Jun 17, 2012
@dstroot
Copy link

dstroot commented Jun 26, 2012

OK - Node v0.8 is out... status?

@mlegenhausen
Copy link

Are you removing node-fork as dependency, which currently causes the installation to fail?

@AvianFlu
Copy link
Contributor Author

This refactor is being worked on presently. The node-fork error can be removed with npm install --force, but forever@0.9.2 behaves strangely on node 0.8.0. There will be a branch available for public testing of the upcoming release starting later today or tomorrow.

node 0.8.0 includes several awesome new features for child processes, and it's a much better use of development resources to refactor the project to take advantage of these, rather than, say, to port daemon.node to the modern age.

@AvianFlu
Copy link
Contributor Author

The node-0.8 branch is now passing its tests, but needs user testing:

git clone https://github.com/nodejitsu/forever
cd forever
git checkout node-0.8
sudo npm link .

Please test!

@dstroot
Copy link

dstroot commented Jul 1, 2012

OK - testing and working well so far. However I am seeing this message:

path.existsSync is now called fs.existsSync.

So somewhere it is using a deprecated call.

@msiebuhr
Copy link

msiebuhr commented Jul 3, 2012

Follow the bug - watch the movie. ;)

@indexzero
Copy link
Member

forever@0.10.0 is now published and only works on node@0.8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants