Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockerfileValidationImpl should not be accessed directly #8

Closed
gastaldi opened this issue Jun 29, 2015 · 2 comments
Closed

DockerfileValidationImpl should not be accessed directly #8

gastaldi opened this issue Jun 29, 2015 · 2 comments
Assignees
@devanshu911
Milestone
1.0.0.Alpha2

Comments

@gastaldi
Copy link
Member

DockerfileValidationImpl should be hidden from the API consumer and therefore should only be accessed through DockerFileResource.verify(). The tests should be changed to use that. Maybe the class name should be changed as well.
@gastaldi gastaldi added this to the 1.0.0.Alpha2 milestone Jun 29, 2015
@gastaldi
Copy link
Member Author

gastaldi commented Jul 1, 2015

See #9 for some information about the class name change

@devanshu911
Copy link
Contributor

Fixed with #14 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devanshu911 devanshu911

Labels
None yet
Projects
None yet
Milestone
1.0.0.Alpha2
Development

No branches or pull requests
2 participants
@gastaldi @devanshu911