Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom-text-editor.Object.defineProperty.get is deprecated. #20

Closed
carolfalardeau opened this issue Jan 13, 2017 · 4 comments
Closed

atom-text-editor.Object.defineProperty.get is deprecated. #20

carolfalardeau opened this issue Jan 13, 2017 · 4 comments

Comments

@carolfalardeau
Copy link

The contents of atom-text-editor elements are no longer encapsulated
within a shadow DOM boundary. Please, stop using shadowRoot and access
the editor contents directly instead.

atom-text-editor.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:68:18)
ruler-view.getEditor (/Users/noovo/.atom/packages/rulerz/lib/ruler-view.coffee:38:33)
ruler-view.insert (/Users/noovo/.atom/packages/rulerz/lib/ruler-view.coffee:45:14)
ruler-view.initialize (/Users/noovo/.atom/packages/rulerz/lib/ruler-view.coffee:30:12)
createView (/Users/noovo/.atom/packages/rulerz/lib/ruler-manager.coffee:25:32)
ViewRegistry.createView (/Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:117:78)
@sergeysova
Copy link

@BattleBrisket @cmtonkinson Please, fix it

@BattleBrisket
Copy link
Member

See comment on #21

@cmtonkinson
Copy link
Member

Thanks for using rulerz, and caring enough to submit a bug report! We're no longer actively using Atom day-to-day, and so haven't devoted a great deal of time to the package. If you're interested in picking up maintainership, please let me know.

@chmac
Copy link
Collaborator

chmac commented Mar 21, 2018

Hopefully this was fixed in #22. Closing.

@chmac chmac closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants