ENTREP-88 Remove non-sanctioned behaviors: Part II #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparklerfish
commented
Jul 18, 2023
mpqmpqm
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Good stuff. A couple discovered loose ends for you to please address:
- rm helper tip that says
Press Enter to add textwhen a container is selected - rm
Wrap text in a containeraction when right click on text element
edit: missed important comment. alt-drag to duplicate still works for me. Doesn't for you?
I swear it didn't before, but I confirmed it still did, so, fixed now. |
mpqmpqm
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Excellent.
en.json/hints is a another valuable source for undesired behaviors. We'll need to address hints.lineEditor_pointSelected at some point, but I actually want to bring that functionality back so we'll do that in a future ticket.
For now, please disabled hints.text and this is good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few more shortcuts/behaviors to squash while working on this. Duplicate via opt-drag/alt-drag was handled in the previous PR. Most stuff is just commented out rather than deleted in case we want to reintroduce them with tokens somehow.