Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Japanese characters rendered incorrectly on avatars #176

Closed
gageas opened this issue Feb 26, 2019 · 8 comments
Closed

[Bug] Japanese characters rendered incorrectly on avatars #176

gageas opened this issue Feb 26, 2019 · 8 comments
Milestone

Comments

@gageas
Copy link

@gageas gageas commented Feb 26, 2019

Hello from Japan!
I found that initial letter of user name displayed as blank rectangle(), which indicates character code is invalid (Mojibake).
This problem happens when user name contains multi-byte characters such as Hanzi
Please see attached pic.

In this example, I git inited new repo, then make a commit with user name 漢字 名前.

I'm not sure what happening inside, but guess that taking first one byte of name instead of first one letter.

default

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Feb 26, 2019

Hi ! But where is that blank rectangle on the screenshot?

Loading

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Feb 26, 2019

Ah, I see. The avatar icon :).
@TanyaPristupova please have a look.

Loading

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Feb 26, 2019

I just checked, the abbreviated text is correct (漢名).

The WPF rendering is the problem. It can't draw such text on a canvas. Not sure why.

Loading

@gageas
Copy link
Author

@gageas gageas commented Feb 26, 2019

Thank you for super quick response.

Ah, I see. The avatar icon :).

Yes it is. Others are fine.

I just checked, the abbreviated text is correct (漢名).

The WPF rendering is the problem. It can't draw such text on a canvas. Not sure why.

Then, how about font?
Can you try Japanese or Chinese font such as "SimHei" and "Yu Gothic"?

ref. List of typefaces included with Microsoft Windows

Loading

@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Feb 26, 2019

"Meiryo", "Meiryo UI" and "SimHei" don't work.

Surprisingly, "Yu Gothic" solved the problem.

image

I'll try to use "Yu Gothic" as a fallback font, but I don't promise it will always be like that. Hopefully other people won't have problems. We will see in 1.29.

I'd propose you to use latin transliteration of your credentials to be sure it's displayed correctly.

Loading

@gageas
Copy link
Author

@gageas gageas commented Feb 26, 2019

Oh, it's mystery. 😅
I'll write a feedback after trying 1.29.

I'd propose you to use latin transliteration of your credentials to be sure it's displayed correctly.

That's true.
I think it is reasonable to giving up to support non-latin name, if having trouble.

Loading

@DanPristupov DanPristupov added this to the 1.29 milestone Feb 26, 2019
@DanPristupov DanPristupov changed the title [Bug]Initial letter displayed incorrectly when using multi-byte character as user name [Bug] Japanese characters rendered incorrectly on avatars Mar 1, 2019
@DanPristupov
Copy link
Contributor

@DanPristupov DanPristupov commented Mar 1, 2019

1.29 just came out. Please check for updates.

Loading

@gageas
Copy link
Author

@gageas gageas commented Mar 2, 2019

Thanks!
1.29.1.0 works perfectly!!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants