Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null check inside append() #147

Closed
mavrick opened this issue Oct 6, 2015 · 4 comments
Closed

null check inside append() #147

mavrick opened this issue Oct 6, 2015 · 4 comments

Comments

@mavrick
Copy link

mavrick commented Oct 6, 2015

Hey,

Can we get a null check or an undefined check on the value param inside the FormData.prototype.append function please?

/lib/form_data.js:25

if (typeof value == undefined)
{
    this._error(new Error('Undefined values are not supported.'));
    return;
}

Otherwise you end up with an uncaught exception inside of FormData.prototype._multiPartHeader on line 151

Cheers

@DylanPiercey
Copy link
Member

@mavrik in @2.0 we are going to String all values in am effort to make the api symmetrical to the browser api which will fix this issue.

@DylanPiercey
Copy link
Member

@alexindigo I think we should update this sooner than later, what's your thoughts?

@magicdawn
Copy link

how is this going on ?

@DylanPiercey
Copy link
Member

Going to close this as a duplicate of #137.

Hope to tackle this soon.

@DylanPiercey DylanPiercey marked this as a duplicate of #137 Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants