Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib/form_data.js #18

Closed
wants to merge 1 commit into from
Closed

Update lib/form_data.js #18

wants to merge 1 commit into from

Conversation

grkov90
Copy link

@grkov90 grkov90 commented Nov 6, 2012

bitter experience .... = - \

bitter experience .... = - \
@alexindigo
Copy link
Member

Can you explain why?
Thank you.

@grkov90
Copy link
Author

grkov90 commented Nov 9, 2012

  • parsedUrl.pathname contains only the path (file) name ( POST /upload )
  • parsedUrl.path contains the name of the path and query string for 'GET' request (POST /upload?fileId=1& ... )

@alexindigo
Copy link
Member

What I meant is the reason you need to pass some parameters in query string (as in GET) while performing POST request. Doesn't really make sense.

@grkov90
Copy link
Author

grkov90 commented Nov 9, 2012

For example, in api known in Russia social network vk.сom must unload file to specify parameters get =)

@alexindigo
Copy link
Member

I see. I would say it's an optional (edge case) behavior rather than default one.
Do you care to refactor your patch to make it as optional parameter with supporting tests.

Thank you.

@alexindigo
Copy link
Member

Now (#22) you can specify custom parameter (like path) when calling form.submit().
For example code please refer to the Readme.

Thank you.

@alexindigo alexindigo closed this Jan 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants