fix(@formatjs/cli): use readJSONSync instead of require
#1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested this out as per the documentation here - https://formatjs.io/docs/getting-started/message-distribution - but every time I ran the command I got ``` Error: Cannot find module './lang/en.json' Require stack: - /Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/src/compile.js - /Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/src/cli.js - /Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/bin/formatjs at Function.Module._resolveFilename (internal/modules/cjs/loader.js:966:15) at Function.Module._load (internal/modules/cjs/loader.js:842:27) at Module.require (internal/modules/cjs/loader.js:1026:19) at require (internal/modules/cjs/helpers.js:72:18) at Object.compile [as default] (/Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/src/compile.js:7:20) at Command.<anonymous> (/Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/src/cli.js:156:41) at Command.listener [as _actionHandler] (/Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/node_modules/commander/index.js:413:31) at Command._parseCommand (/Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/node_modules/commander/index.js:914:14) at Command._dispatchSubcommand (/Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/node_modules/commander/index.js:865:18) at Command._parseCommand (/Users/adamjenkins/Documents/GitHub/web-client/node_modules/@formatjs/cli/node_modules/commander/index.js:882:12) adamjenkins@MacBook-Pro web-client % npx formatjs compile ./lang/en.json --out-file compiled-lang/en.json ``` When I changed it to use readJSONSync (because the cli already uses fs-extra so why not) it worked like a charm. I didn't see a bug report, is anybody else experiencing this issue?
|
Thanks a lot for your contributions! |
longlho
changed the title
readJSONSync instead of require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this out as per the documentation here - https://formatjs.io/docs/getting-started/message-distribution - but every time I ran the command I got
When I changed it to use readJSONSync (because the cli already uses fs-extra so why not) it worked like a charm. I didn't see a bug report, is anybody else experiencing this issue?