Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove babel-eslint #383

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Remove babel-eslint #383

merged 1 commit into from
Mar 31, 2016

Conversation

ericf
Copy link
Collaborator

@ericf ericf commented Mar 31, 2016

babel-eslint released a patch version which caused the built to break. This removes babel-eslint because it's not currently needed.

@ericf ericf merged commit e721a6b into formatjs:master Mar 31, 2016
@ericf ericf deleted the remove-babel-eslint branch March 31, 2016 21:24
@hzoo
Copy link
Contributor

hzoo commented Apr 1, 2016

The patch version had to do with "sourceType": "module" since we were hardcoding the value in babel-eslint, but it was reverted since it was breaking. But if you don't need it 👍

longlho added a commit that referenced this pull request Apr 27, 2020
@longlho
fix(@formatjs/cli): glob files instead of relying on shell, fix #383
c1126b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericf @hzoo