fix(@formatjs/intl): update IntlFormatters.formatNumber value type #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formatNumber and formatNumberToParts should support string values as indicated in MDN docs. Unfortunately, it seems like `Intl.NumberFormat` type in V8 doesn't explicitly strings which contradicts what is indicated in the documentation and what happens when a string value is passed in, so I've case the `value` as a `number` in `number.ts`.
update to expect string value types to reflect changes made in @formatjs/intl
update to expect string value types to reflect changes made in @formatjs/intl
update docs to reflect type updates
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
looks like u'd have to fix TypeScript inlt lib d.ts itself before making this patch |
|
I see, thanks for the comment @longlho. I'll close the loop in the issue that I opened with reference to your comment. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened #3949 because I noticed a TS error was being thrown when passing a
stringtype value toformatNumber, which I don't believe should be raised sinceIntl.FormatNumber.prototype.formatdoes support string values as indicated herePlease let me know if there's anything I've missed! Apologies if I've jumped the gun on creating a PR prior to having my issue triaged 馃檹馃徎