intl-localematcher: Incorrect locale information provided with '*'

[tkrotoff]

Which package?

@formatjs/intl-localematcher

Describe the bug

import { match } from "@formatjs/intl-localematcher"

match(['*'], ['en'], 'en');

// => Throws "RangeError: Incorrect locale information provided"

[longlho]

'*' is not a valid locale

[tkrotoff]

Yes

new Intl.Locale('*') => RangeError: Incorrect locale information provided

However

HTTP header Accept-Language can be * cf https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Language#sect1

So you would expect code like this to work:

import { match } from "@formatjs/intl-localematcher"

// Derived from HTTP header Accept-Language
// For example using https://github.com/jshttp/negotiator
// const preferredLocales = new Negotiator({ headers }).languages();
const preferredLocales = ['*'];

const availableLangs = ['nl', 'fr', 'de'];
const defaultLang = availableLangs[0];

match(preferredLocales, availableLangs, defaultLang);
// => 'nl' (defaultLang)

[longlho]

Conceptually your client expects any locale, so there's no need to locale match you can just return any of the locales you support.

[longlho]

Again, the locale we expect is Unicode Locale Identifier and * is not a valid locale