Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Manifest template support for targets with packageName attribute #33

Closed
stepango opened this issue Nov 10, 2020 · 2 comments
Closed
Assignees
Labels
feature request Necessary features for development

Comments

@stepango
Copy link
Collaborator

stepango commented Nov 10, 2020

Right now packageName we define in build config and package in the manifest is just duplicated.
So what we need is create a universal manifest file, smth like:

<?xml version="1.0" encoding="utf-8"?>
<manifest package="${packageName}"/>

And make sure the generation of this file is automated for every new target, or even better - use a symlink(or some other approach) to a single file for all targets which need manifest. So having AndroidManisest in every target will become obsolete

We can figure out manifest extensions for Activities later. (Like merge universal template with additional provided manifest file)

@issue-label-bot issue-label-bot bot added the feature request Necessary features for development label Nov 10, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@stepango
Copy link
Collaborator Author

Already implemented via new AGP API's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Necessary features for development
Projects
None yet
Development

No branches or pull requests

2 participants