Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Rework the loading.tsx on PRODUCT pages #2618

Closed
jobenjada opened this issue May 14, 2024 · 3 comments · Fixed by #2666
Closed

[FEATURE] Rework the loading.tsx on PRODUCT pages #2618

jobenjada opened this issue May 14, 2024 · 3 comments · Fixed by #2666
Assignees
Labels
🕹️ deputy enhancement New feature or request good first issue Good for newcomers 🙋🏻‍♂️help wanted Extra attention is needed 🕹️ oss.gg Community issue via oss.gg 🕹️ rookie 🕹️ 50 points

Comments

@jobenjada
Copy link
Member

Is your feature request related to a problem? Please describe.

We've reworked parts of our UI but didn't yet update the loading.tsx in the different files.

This creates a weird visual effect with the loading UI looking different than the actual UI.

Describe the solution you'd like

Rework the loading.tsx to match the actual UI of the /product/ pages.

The most important thing is the card styling: bg-white rounded-xl shadow-sm border border-slate-200

Since it's loading, pls add a Tailwind animation: animate-pulse

The inside of the card isn't super important.

Note: Please only do the loading.tsx of the ticket you are assigned to.

We want to give several contributors the chance to contribute :)

Describe alternatives you've considered

No response

Additional context

No response

@jobenjada jobenjada added enhancement New feature or request good first issue Good for newcomers 🙋🏻‍♂️help wanted Extra attention is needed 🕹️ oss.gg Community issue via oss.gg 🕹️ 50 points labels May 14, 2024
@lovishduggal
Copy link
Contributor

/assign

Copy link

oss-gg bot commented May 20, 2024

With your current level, you are not yet able to work on this issue. Please have a look on oss.gg to see which levels can work on which issues 🤓

@Kiran-Alex
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹️ deputy enhancement New feature or request good first issue Good for newcomers 🙋🏻‍♂️help wanted Extra attention is needed 🕹️ oss.gg Community issue via oss.gg 🕹️ rookie 🕹️ 50 points
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants