Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying the same for and id breaks clicking behavior for checkboxes and radios #32

Closed
julien-c opened this issue Nov 19, 2012 · 3 comments
Labels

Comments

@julien-c
Copy link
Contributor

When writing echo Former::radios('agreement')->radios('Non', 'Oui');, Former uses the same ids and for tabs for both elements, which breaks label clicking behavior:

Compare:

    <div class="controls">
        <label class="radio"><input checked="checked" id="agreement" type="radio" name="agreement" value="0">Non</label>
        <label class="radio"><input id="agreement" type="radio" name="agreement" value="1">Oui</label>
    </div>

to Bootstrap's examples:
http://twitter.github.com/bootstrap/base-css.html#forms

Cheers!

@Anahkiasen
Copy link
Member

This should be fixed in the latest commit, can you check ?

@julien-c
Copy link
Contributor Author

It does, thanks! Although, do you really need ids and fors at all?

@Anahkiasen
Copy link
Member

Actually it's Laravel that enforces them so it's a little more complicated than it seems, but yeah it's always good practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants