Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Don't work if set slug in app.json #7

Closed
giautm opened this issue Jul 27, 2017 · 4 comments
Closed

Don't work if set slug in app.json #7

giautm opened this issue Jul 27, 2017 · 4 comments

Comments

@giautm
Copy link

giautm commented Jul 27, 2017

slug is required in app.json.
If i set that field, appr don't work anymore. Because if still publish to that slug.
@tonyxiao
Copy link
Contributor

tonyxiao commented Dec 3, 2017

Same issue here.

@giautm
Copy link
Author

giautm commented Dec 3, 2017

@tonyxiao : You can fork and edit as i done to make it work:
master...giautm:master

@tonyxiao
Copy link
Contributor

tonyxiao commented Dec 3, 2017

Yea I ended up checking that out. Thanks @giautm

@jevakallio
Copy link
Contributor

jevakallio commented Dec 4, 2017 •
edited

This should now be fixed and released as v1.1.0. Thanks @giautm and @tonyxiao! 🙇

I'm closing this issue, please reopen if the issue persists!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tonyxiao @jevakallio @giautm