You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
// ROOT"scripts": {"test": "builder run check"},// ARCHETYPE"scripts": {"check": "builder run lint && builder run test"},
and then run:
$ npm test
and watch an infinite loop of the same task...
The lint command works just fine, but builder run test in the archetype hits the ROOT test task recursively firing up everything again, and again, and again, ...
TASK: Research a way to detect and deal with:
Maybe keep builder task spawn state in environment?
Refactor our archetypes to make npm:testreally be something worth of npm test in ROOT and remove archetype test commands.
Detect and error in archetypes on npm lifecycle commands (?) (Orthogonal, but related -- can have recursive blow up with completely custom commands too.)
Update the README to not have test be an example of overriding commands.
"scripts": {
"check": "npm run lint && npm run test",
"lint": "echo OK",
"test": "npm run check"
}
...but perhaps a little easier with Builder since you're not looking at the full list of tasks when you edit package.json. I'm inclined to just add a word of caution to the docs instead of figuring out a technical solution.
An easy footgun with the existing https://github.com/FormidableLabs/builder-react-component/blob/master/package.json is if in:
and then run:
$ npm test
and watch an infinite loop of the same task...
The
lint
command works just fine, butbuilder run test
in the archetype hits the ROOTtest
task recursively firing up everything again, and again, and again, ...TASK: Research a way to detect and deal with:
npm:test
really be something worth ofnpm test
in ROOT and remove archetypetest
commands.test
be an example of overriding commands./cc @coopy @chaseadamsio
The text was updated successfully, but these errors were encountered: