Actually prevent passive touchmove events default behavior

[fastory-automation]

It’s possible to listen to touchmove manually to ensure the listener has the ability to prevent the default event behavior. Otherwise it’s impossible to let users scroll vertically while playing a video with audio enabled on horizontal swipe in Chrome 56+.

[hartzis]

@kontest @kl0tl Thanks for the PR, i've been interested in a solution to this for a while. I like where you're going with this and the simple detect-passive-events package.

I'd like to see if we could add tests and possibly move the newProps.ref function into the constructor so it doesn't get rebound on every render.

I'm hoping to take a deeper look at this and compare this solution to react-easy-swipe's solution too 😄

[kl0tl]

@hartzis I’ve moved the definition of the ref handler out of render! I’m not really sure about what to test. Do you think testing an active touchmove listener is manually added on window if passive events are supported and preventDefaultTouchmoveEvent is enabled would be enough ?

[hartzis]

You rock @kl0tl ! I'll try to get this merged and published this week. Should be just a minor bump. So 4.2.0.

If you feel exceedingly ambitious, could mimic the tests here ish, if not, i may attempt after the merge.

Cheers!

[hartzis]

pulled down the branch, did some testing and some research. Moved the listener setup inside react lifecycle methods to avoid the ref being null.