Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

victory-area #40

Closed
boygirl opened this issue Nov 16, 2015 · 6 comments · Fixed by FormidableLabs/victory-chart#103
Closed

victory-area #40

boygirl opened this issue Nov 16, 2015 · 6 comments · Fixed by FormidableLabs/victory-chart#103
Assignees
@boygirl
Labels
Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release

Comments

@boygirl
Copy link
Contributor

boygirl commented Nov 16, 2015

No description provided.

@knowbody
Copy link
Contributor

knowbody commented Jan 4, 2016

@boygirl can you give more details on this, please

@knowbody knowbody added the Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release label Jan 4, 2016
@boygirl
Copy link
Contributor Author

boygirl commented Jan 4, 2016

This component should render something similar to what line renders, but filled in down to the axis. That part should pretty much be copy and paste from the line component, and then a little more logic to complete the path. The complicated part is figuring out stacked areas.

@austinpray
Copy link
Contributor

If you need more details:

image

The red should fill down to the very bottom instead of intersecting

@jakepusateri
Copy link

An example of a stacked area chart.
image

@vansters-dev
Copy link

+1

@F21
Copy link

F21 commented Feb 8, 2016

Just noticed that adding a fill style to victory-line doesn't really work, so would love to see this happen too!

divmain pushed a commit that referenced this issue Feb 16, 2016
Merge pull request #40 from FormidableLabs/docsForRelease
3aa703d 
Docs for release
divmain pushed a commit that referenced this issue Feb 16, 2016
@knowbody
Merge pull request #40 from FormidableLabs/bug-fixHotReloading
2d4c1ac 
Bug fix hot reloading
divmain pushed a commit that referenced this issue Feb 16, 2016
Merge pull request #40 from FormidableLabs/knowbody-patch-1
2d5e592 
add warning to postinstall
@boygirl boygirl self-assigned this Feb 22, 2016
@boygirl boygirl mentioned this issue Feb 22, 2016
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boygirl boygirl

Labels
Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/victory area FormidableLabs/victory-chart
6 participants
@austinpray @F21 @jakepusateri @boygirl @knowbody @vansters-dev