New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging and module declarations and references in /Dist #50
Comments
Dependency issues were solved by adding necessary paths to various packages in systemjs configuration as would be expected. But the need to import from 'ng2-formio/dist/index' seems odd. |
I am having a hard time figuring out what is different from the people who are saying there is an issue with the packaging vs. getting Form.io into something like ng-admin which I did not need to refer to the full path. I am open to suggestions from anyone in the community who would like to help out with this. |
Things worked fine with v0.5.0, I'm guessing something changed with this commit . There used to be a "typings" entry in package.json, which would be needed here (AFAIK). Readding the "types"/"typings" field alone was not enough to fix it, though. Afterwards, the import from plain "ng2-formio" (no "/dist/index") works, but I get a compilation error.
Not sure how much that helps, but it's a start, at least. TypeScript version differences could also be another reason. A related note: the version of @types/jasmine needs to be locked to 2.5.41, they made a breaking change in a patch version (they use typescript 2.1 features, so it's no longer compatible with TS 2.0). |
Thank you so much @pkt-zer0. I just resolved the issue with formio.js with version 1.5.3. I will add the typings entry within package.json and see if that fixes the problem. |
So, I just released version 0.9.3 with this fix in place. Let me know if that works for you guys. |
The issue with @types/jasmine breaking the build (unless locked to 2.5.41) is still there. (You might need to delete node_modules to reproduce this) Otherwise it works now, thanks! |
Issues with atom-typescript recognizing import:
Also get typescript error when transpiling.
Properly recognizes if using the following import:
However, systemjs does not properly find dependencies if importing this way when building in development.
When trying to bundle for production build
There is an issue with the way the dist/index.js is exporting the module and/or the dependency of formio.js. Typescript and subsequently systemjs isn't picking up the module or dependency references properly.
Using build system from https://github.com/mgechev/angular-seed
The text was updated successfully, but these errors were encountered: