Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React and webpack warnings #20

Closed
batusai513 opened this issue Jun 30, 2016 · 5 comments
Closed

React and webpack warnings #20

batusai513 opened this issue Jun 30, 2016 · 5 comments

Comments

@batusai513
Copy link
Contributor

batusai513 commented Jun 30, 2016

hi, i'm working with this library in a webpack application, but i'm getting these warnings:

Warning: React.__spread is deprecated and should not be used. Use Object.assign directly or another helper function with similar semantics. You may be seeing this warning due to your compiler. See https://fb.me/react-spread-deprecation for more details.

also i'm getting this in webpack:

WARNING in ./~/react-formio/dist/Formio.js
Critical dependencies: This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
@ ./~/react-formio/dist/Formio.js 343:501-508

Al so, when using a date component in form.io, the react component associated with the date component does not have any styles.

@randallknutson
Copy link
Contributor

Both of these are harmless warnings. You can eliminate them by using this to include Formio

var Formio = require('react-formio/src/Formio.jsx');

@batusai513
Copy link
Contributor Author

@randallknutson that wont work because i'm using webpack and i'm excluding node_modules, so it throws when it find jsx, i'm going to try to change the main from package.json and add a script to build but not minify the bundle.

@randallknutson
Copy link
Contributor

I'm in favor of this change so let me know if you figure it out.

@batusai513
Copy link
Contributor Author

@randallknutson #26

@randallknutson
Copy link
Contributor

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants