New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all folder "index_key" mentions to "folder_key" and replace /indices/folder/move #178

Open

reganwolfrom opened this issue Sep 29, 2023 · 0 comments

Labels

v2.0

Member

reganwolfrom commented Sep 29, 2023 •

edited

Loading

NOTE: This change would cause a break for /folders endpoints, and would require the deprecation of /indices/folder/move

/indices/folder/move would become /folders/{folder_key}/move, and would also have an optional {share_key} param; we may still want to have an /indices/{index_type}/move endpoint, but I don't know that we need it atm
GET /folders and DELETE /folders/{index_key} would use {folder_key} instead of {index_key}
GET /shares and POST /shares/folders/{index_key} would use {folder_key} instead of {index_key}

There may be other instances of index_key that need to be changed.

reganwolfrom added the v2.0 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment