Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask field doesn't fire dom-input-event on user's input #1011

Closed
exoort opened this issue Oct 24, 2023 · 2 comments
Closed

Mask field doesn't fire dom-input-event on user's input #1011

exoort opened this issue Oct 24, 2023 · 2 comments
Assignees
@justin-schroeder
Labels
🐛 bug Verified bug by team 🔵 priority-3 3. Lower priority issue Pro Pertains to FormKit Pro 🚀 release-ready Feature or fix is complete and on an upcoming release branch

Comments

@exoort
Copy link

exoort commented Oct 24, 2023

Reproduction

https://formkit.link/9042cd4334b0e0cf8c02f3387c0f8781

Describe the bug

Simple text field (type="text") fires dom-input-event, but field with mask (type="mask") not. I think that we can add such code https://github.com/formkit/formkit/blob/master/packages/inputs/src/sections/textareaInput.ts#L15 for mask field. I tested this solution for bundled mask and its working.

Environment

• OS: macOS
• Browser: Chrome
• Version: 118.0.5993.88 (Official Build) (arm64)
@exoort exoort added ⛑ Needs triage The issue has not yet been examined by the FormKit team. 🐛 bug-report Bug is reported, but not verified by team labels Oct 24, 2023
@exoort exoort changed the title Mask field don't fire dom-input-event on user's input Mask field doesn't fire dom-input-event on user's input Oct 24, 2023
@sashamilenkovic sashamilenkovic added 🐛 bug-report Bug is reported, but not verified by team ⛑ Needs triage The issue has not yet been examined by the FormKit team. and removed 🐛 bug-report Bug is reported, but not verified by team ⛑ Needs triage The issue has not yet been examined by the FormKit team. labels Oct 24, 2023
@justin-schroeder justin-schroeder added 🐛 bug Verified bug by team 🔵 priority-3 3. Lower priority issue Pro Pertains to FormKit Pro and removed 🐛 bug-report Bug is reported, but not verified by team ⛑ Needs triage The issue has not yet been examined by the FormKit team. labels Dec 12, 2023
@justin-schroeder justin-schroeder self-assigned this Dec 12, 2023
@justin-schroeder justin-schroeder added the 🚀 release-ready Feature or fix is complete and on an upcoming release branch label Jan 30, 2024
@dreamerrrrrrrrr
Copy link

@justin-schroeder It's been ready for release for 2 months, when can we expect a release with this fix?

@justin-schroeder
Copy link
Member

@justin-schroeder It's been ready for release for 2 months, when can we expect a release with this fix?

Congrats on joining GitHub today! Release within perhaps the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justin-schroeder justin-schroeder

Labels
🐛 bug Verified bug by team 🔵 priority-3 3. Lower priority issue Pro Pertains to FormKit Pro 🚀 release-ready Feature or fix is complete and on an upcoming release branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@justin-schroeder @exoort @sashamilenkovic @dreamerrrrrrrrr