Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing TypeScript Annotation in Beta 5 for @submit Handler's Node Property #130

Closed
joneath opened this issue Mar 8, 2022 · 1 comment
Closed
Labels
🐛 bug Verified bug by team 🚀 release-ready Feature or fix is complete and on an upcoming release branch

Comments

@joneath
Copy link

joneath commented Mar 8, 2022

Reproduction

https://github.com/formkit/formkit/blob/master/packages/vue/src/FormKit.ts#L23

Describe the bug

Sorry no playground example as the environment is not typescript so can't reproduce there.

In the docs and in working code it shows that the @submit method for a form passes both data and node to the handler but when you attempt to implement this function signature you get the following typescript error:
Screen Shot 2022-03-08 at 11 34 29

Here's the offending line:
https://github.com/formkit/formkit/blob/master/packages/vue/src/FormKit.ts#L23

Environment

• macOS 12.2.1
• Chrome but N/A
• 98.0.4758.109

@joneath joneath added the 🐛 bug-report Bug is reported, but not verified by team label Mar 8, 2022
@justin-schroeder justin-schroeder added 🐛 bug Verified bug by team and removed 🐛 bug-report Bug is reported, but not verified by team labels Mar 8, 2022
@justin-schroeder justin-schroeder added the 🚀 release-ready Feature or fix is complete and on an upcoming release branch label Mar 8, 2022
@justin-schroeder
Copy link
Member

This is fixed and published on the @next release tag.

@justin-schroeder justin-schroeder added this to the Beta 6 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Verified bug by team 🚀 release-ready Feature or fix is complete and on an upcoming release branch
Projects
None yet
Development

No branches or pull requests

2 participants