Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom icon-loader is not called for default default internal icon names. #1301

Open
justin-schroeder opened this issue Apr 9, 2024 · 1 comment
Assignees
Labels
🐛 bug Verified bug by team

Comments

@justin-schroeder
Copy link
Member

Reproduction

https://formkit.link/b2193fbf255e0af8803ab07f630a1c90

Describe the bug

Both the autocomplete and the checkbox use a "default" icon of check. When using a custom icon loader the loader is never called for these — furthermore, it then caches/memoizes the "nothing" value as being the value of the icon resolution. So anywhere check is used as an icon fails.

Environment

• OS: macOS
• Browser Chrome
• Version 1.6.2

@justin-schroeder justin-schroeder added the 🐛 bug Verified bug by team label Apr 9, 2024
@andrew-boyd
Copy link
Member

@justin-schroeder Given the work being done in 1.7 related to icon loaders do you think this needs to be addressed? Or can it we consider it fixed in upcoming work represented by 1.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Verified bug by team
Projects
None yet
Development

No branches or pull requests

2 participants