Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Togglebuttons: <li> elements must be contained in a <ul> or <ol> [accessibility] #1334

Closed
Aellynd opened this issue Apr 25, 2024 · 2 comments
Assignees
Labels
🐛 bug Verified bug by team 🔵 priority-3 3. Lower priority issue Pro Pertains to FormKit Pro

Comments

@Aellynd
Copy link

Aellynd commented Apr 25, 2024

Reproduction

https://formkit.link/cd719fb7236742ebf0d39717ad863c9e

Describe the bug

Hi, we just upgraded to @formkit/pro@0.122.19 and noticed a new accessibility issue was introduced in this finding as a result of a fix in #1326:

  • <li> elements must be contained in a <ul> or <ol> (User Impact: Serious, Guidelines: WCAG 2.1 (A), WCAG 2.0 (A), WCAG 2.2 (A), EN 301 549)

This is due to the <ul> having role="group".

I hope it is clear, otherwise feel free to ask me more questions.
Thanks in advance!

Environment

• Windows 10 Pro
• Chrome 124.0.6367.61

@Aellynd Aellynd added ⛑ Needs triage The issue has not yet been examined by the FormKit team. 🐛 bug-report Bug is reported, but not verified by team labels Apr 25, 2024
@sashamilenkovic sashamilenkovic self-assigned this Apr 25, 2024
@sashamilenkovic sashamilenkovic added 🐛 bug Verified bug by team 🔵 priority-3 3. Lower priority issue Pro Pertains to FormKit Pro and removed 🐛 bug-report Bug is reported, but not verified by team ⛑ Needs triage The issue has not yet been examined by the FormKit team. labels Apr 25, 2024
@sashamilenkovic
Copy link
Contributor

@Aellynd This should be addressed at FormKit Pro v0.122.20. I validated that this passes checks on lighthouse. Please let us know if you see any more issues. Thanks.

@Aellynd
Copy link
Author

Aellynd commented Apr 29, 2024

Thank you @sashamilenkovic! Again, the quick action and response is much appreciated. I can confirm there are no more accessibility issues for the toggle buttons 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Verified bug by team 🔵 priority-3 3. Lower priority issue Pro Pertains to FormKit Pro
Projects
None yet
Development

No branches or pull requests

2 participants