Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taglist field not deleting items on click / backspace #1345

Closed
IsraelOrtuno opened this issue May 8, 2024 · 12 comments
Closed

Taglist field not deleting items on click / backspace #1345

IsraelOrtuno opened this issue May 8, 2024 · 12 comments
Assignees
Labels
🐛 bug Verified bug by team 🔴 priority-1 1. Top priority issue Pro Pertains to FormKit Pro

Comments

@IsraelOrtuno
Copy link

IsraelOrtuno commented May 8, 2024

Reproduction

https://formkit.link/d36ac2869389a78860db1bcb18c18887

Describe the bug

The taglist does not delete items when clicking on the "X" or using the backspace key. It's not working on dev nor the entire documentation page. Nothing shows in the console. It works when selecting an existing item tho.

Edit: Just switched the FormKit version to 1.7.x and seems to work.

Environment

• OS: macOS
• Browser Chrome
• Version 124.0

@IsraelOrtuno IsraelOrtuno added ⛑ Needs triage The issue has not yet been examined by the FormKit team. 🐛 bug-report Bug is reported, but not verified by team labels May 8, 2024
@IsraelOrtuno IsraelOrtuno changed the title Taglist field not deleting Taglist field not deleting items on click / backspace May 8, 2024
@justin-schroeder
Copy link
Member

Hmm. it works for me on 1.6.2 as well.

@IsraelOrtuno
Copy link
Author

So strange! Failing to me on Chrome and Safari, also on my iPhone.

Screen.Recording.2024-05-09.at.08.41.33.mov
Screen.Recording.2024-05-09.at.08.42.56.mov

@sashamilenkovic
Copy link
Contributor

@IsraelOrtuno I'm also having a hard time replicating this.

Can you tell me which version of FormKit Pro you have installed locally? And then for the FormKIt playground, would you mind checking which version of FormKit Pro you are receiving from the CDN. You can filter your network tab in dev tools like so:

Screenshot 2024-05-09 at 6 08 14 AM

@IsraelOrtuno
Copy link
Author

Seems like the same as you. It's also failing when selecting <= 1.6 versions and in the whole docs website... I have tried in a Chrome on a different Macbook and just the same behaviour, also asked a friend but same. I have 0.125.0 in my local env too.

Seems to work in the docs megamenu tho, not sure why but maybe that helps.

image image

@sashamilenkovic
Copy link
Contributor

@IsraelOrtuno I'm now seeing it as well without the version having changed. Very odd. Works fine locally for me though... I'm not quite sure yet. I will look into this. Thanks for bringing this up!

@sashamilenkovic
Copy link
Contributor

@IsraelOrtuno Can you confirm that reverting FormKit Pro to 0.124.2 resolves this issue?

@sashamilenkovic sashamilenkovic self-assigned this May 9, 2024
@sashamilenkovic sashamilenkovic added 🐛 bug Verified bug by team 🔴 priority-1 1. Top priority issue Pro Pertains to FormKit Pro and removed 🐛 bug-report Bug is reported, but not verified by team ⛑ Needs triage The issue has not yet been examined by the FormKit team. labels May 9, 2024
@IsraelOrtuno
Copy link
Author

@IsraelOrtuno Can you confirm that reverting FormKit Pro to 0.124.2 resolves this issue?

Yes, 0.124.2 works!

@IsraelOrtuno
Copy link
Author

IsraelOrtuno commented May 9, 2024

Moved back to ^0.125.0 and seems to work, not sure what's going on.

@IsraelOrtuno
Copy link
Author

Said nothing, not working sorry.

@sashamilenkovic
Copy link
Contributor

Okay, seems specific to a build issue with FormKit Pro v0.125.0. We're continuing to look into this.

@sashamilenkovic
Copy link
Contributor

@IsraelOrtuno This should be resolved at FormKit Pro v0.125.1. Thanks so much for letting us know!

@IsraelOrtuno
Copy link
Author

Thanks to you for the rapid action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Verified bug by team 🔴 priority-1 1. Top priority issue Pro Pertains to FormKit Pro
Projects
None yet
Development

No branches or pull requests

3 participants