Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix for HD Counter #39

Open
ibweb opened this issue Mar 24, 2023 · 6 comments
Open

Prefix for HD Counter #39

ibweb opened this issue Mar 24, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@ibweb
Copy link

ibweb commented Mar 24, 2023

The current HD counter only allows the Unit to be displayed after the number. This does not work well for USA companies that need to list the dollar sign $ before the number.
Please allow an option to select the Unit to be a prefix or suffix.

Also, we should have the ability to remove the space between the unit and the number.

As an alternate, and perhaps even better, implementation method, it might actually be better to have a prefix unit/symbol field instead. That way you can leave the "Unit" field as it is currently, but also allow users to have both prefix and suffix.
For instance, this would allow a string like "$25,000+" to be present.

Thank you in advance for considering this feature request. We love your plugin!

@ibweb ibweb added the enhancement New feature or request label Mar 24, 2023
@forrestkirby
Copy link
Owner

Please see 8b5f5b9

@ibweb
Copy link
Author

ibweb commented Mar 27, 2023

@forrestkirby The prefix works wonderfully!
However, the "Remove the space character between the prefix and the number" options removes one space. It looks like the counter element by default puts two spaces in between the number and the character. When we enable remove space, it removes only one of the two. As such, that needs to be reconfigured to remove two spaces, not one.
I apologize for missing that on my end when I originally wrote up the Issue.

@forrestkirby
Copy link
Owner

forrestkirby commented Mar 27, 2023

Thanks for testing. I didn’t notice this either and found out that the additional spaces are actually added by the browser if you have line breaks between span elements. This should be fixed with 6951a19. Please try the latest version of the branch https://github.com/forrestkirby/herzogdupont-joomla/tree/feature-counter-prefix.

@ibweb
Copy link
Author

ibweb commented Mar 28, 2023

@forrestkirby I tried the latest version of the branch, and while that fixed the spaces it caused a weird alignment issue for both counters that do and counters that do not use the prefix. See the screenshot below:
weird-formatting

@ibweb
Copy link
Author

ibweb commented Apr 10, 2023

@forrestkirby any luck fixing the above issue?

@ibweb
Copy link
Author

ibweb commented May 9, 2023

@forrestkirby we really need this finalized soon. Have you been able to fix the above issue we reported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants